Messages in this thread | | | Date | Fri, 21 Aug 2015 00:29:23 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support |
| |
On 08/21/2015 12:20 AM, Eduardo Valentin wrote: > On Thu, Aug 20, 2015 at 10:06:01AM +0200, Sascha Hauer wrote: >> This adds support for the Mediatek thermal controller found on MT8173 >> and likely other SoCs. >> The controller is a bit special. It does not have its own ADC, instead >> it controls the on-SoC AUXADC via AHB bus accesses. For this reason >> we need the physical address of the AUXADC. Also it controls a mux >> using AHB bus accesses, so we need the APMIXEDSYS physical address aswell. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> ---
[ ... ]
>> + /* >> + * These calibration values should finally be provided by the >> + * firmware or fuses. For now use default values. >> + */ >> + mt->calib_slope = -123; >> + mt->calib_offset = 465124; > > Would it make sense to use the coefficients device tree property to > describe the sensor slope and offset?
Trim the mail when possible please.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |