lkml.org 
[lkml]   [2015]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Check return code from pdc20621_i2c_read()
    From
    Date
    On Sun, 2015-08-02 at 10:55 -0700, Tomer Barletz wrote:
    > On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
    > <sergei.shtylyov@cogentembedded.com> wrote:
    >
    > > Please use pr_err() instead. And "0x%d" makes no sense at all,
    > > please use "%#x" instead.
    > >
    >
    > Yeah, not sure what I was drinking before writing this 0x%d thing...

    btw: you and a few others ([dui]: debugging under the influence?):

    $ git grep -n -E "0x[\*\d\.]*%[dui]"
    drivers/block/DAC960.c:2957: DAC960_Error("IO port 0x%d busy for Controller at\n",
    drivers/block/DAC960.c:2993: DAC960_Error("IO port 0x%d busy for Controller at\n",
    drivers/block/cciss.c:3857: dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n",
    drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:523: mfc_debug(2, "stream buf addr: 0x%08lx, size: 0x%d\n",
    drivers/misc/sgi-gru/grumain.c:286: gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
    sound/soc/atmel/atmel_ssc_dai.c:293: pr_debug("atmel_ssc_startup: SSC_SR=0x%u\n",

    I'll send a few patches...


    \
     
     \ /
      Last update: 2015-08-02 22:41    [W:4.422 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site