lkml.org 
[lkml]   [2015]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties
On Tue, Aug 18, 2015 at 09:17:06PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris:
> > This DTS file was submitted with non-upstream bindings. I happened
> > across this while reviewing the jaq DTS.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > Cc: Alexandru M Stan <amstan@chromium.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > ---
> > Tested on jaq, not minnie
> >
> > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> > b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index
> > 0e30bd6bf92b..6f619c154dc6 100644
> > --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> > +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> > @@ -128,12 +128,16 @@
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > regulator-name = "vcc33_touch";
> > - regulator-suspend-mem-disabled;
> > + regulator-state-mem {
> > + regulator-on-in-suspend;
> > + };
> > };
> >
> > vcc5v_touch: SWITCH_REG2 {
> > regulator-name = "vcc5v_touch";
> > - regulator-suspend-mem-disabled;
> > + regulator-state-mem {
> > + regulator-on-in-suspend;
> > + };
>
> wouldn't regulator-suspend-mem-disabled translate to regulator-off-in-suspend?
> At least looks like it according to https://lkml.org/lkml/2013/7/25/592

You are right. My bad. Will fix. (Need to fix this in jaq too.)

Thanks,
Brian


\
 
 \ /
  Last update: 2015-08-19 02:01    [W:0.539 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site