Messages in this thread | | | Date | Tue, 18 Aug 2015 12:55:46 +0200 | From | Michal Hocko <> | Subject | Re: [RFC -v2 5/8] ext4: Do not fail journal due to block allocator |
| |
On Tue 18-08-15 12:39:03, Michal Hocko wrote: [...] > @@ -992,9 +992,8 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb, > block = group * 2; > pnum = block / blocks_per_page; > poff = block % blocks_per_page; > - page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS); > - if (!page) > - return -ENOMEM; > + page = find_or_create_page(inode->i_mapping, pnum, > + GFP_NOFS|__GFP_NOFAIL);
Scratch this one. find_or_create_page is allowed to return NULL. The patch is bogus. I was overly eager to turn all places to not check the return value.
-- Michal Hocko SUSE Labs
| |