lkml.org 
[lkml]   [2015]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gpio/grgpio: fix deadlock in grgpio_irq_unmap()
From
On Mon, Aug 17, 2015 at 10:23 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:

> As reported by Alexey Khoroshilov:
>
> grgpio_irq_unmap() code looks quite suspicious regarding usage of
> priv->bgc.lock spinlock.
>
> It locks the spinlock in line 310:
>
> spin_lock_irqsave(&priv->bgc.lock, flags);
>
> and then it can call grgpio_set_imask() in line 317:
>
> grgpio_set_imask(priv, i, 0);
>
> But grgpio_set_imask() unconditionally locks the spinlock by itself.
>
> Fix this by moving the spinlock acquisition outside of
> grgpio_set_imask().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> CC: Alexey Khoroshilov <khoroshilov@ispras.ru>
> CC: Andreas Larsson <andreas@gaisler.com>

Patch applied.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-08-17 11:21    [W:0.042 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site