lkml.org 
[lkml]   [2015]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation
On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote:
> Update the annotation for the kaddr pointer returned by direct_access()
> so that it is a __pmem pointer. This is consistent with the PMEM driver
> and with how this direct_access() pointer is used in the DAX code.

IFF we stick to the __pmem annotations this looks good.

That beeing said I start to really dislike them. We don't special
accesors to read/write from pmem, we just need to explicitly commit
it if we want to make it persistent. So I really don't see the need
to treat it special and require all the force casts to and from the
attribute.


\
 
 \ /
  Last update: 2015-08-15 11:41    [W:0.122 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site