lkml.org 
[lkml]   [2015]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.1 77/84] thermal: exynos: Disable the regulator on probe failure
    Date
    4.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    commit 5f09a5cbd14ae16e93866040fa44d930ff885650 upstream.

    During probe the regulator (if present) was enabled but not disabled in
    case of failure. So an unsuccessful probe lead to enabling the
    regulator which was actually not needed because the device was not
    enabled.

    Additionally each deferred probe lead to increase of regulator enable
    count so it would not be effectively disabled during removal of the
    device.

    Test HW: Exynos4412 - Trats2 board

    Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at device tree")
    Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
    Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
    Tested-by: Lukasz Majewski <l.majewski@samsung.com>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/thermal/samsung/exynos_tmu.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/thermal/samsung/exynos_tmu.c
    +++ b/drivers/thermal/samsung/exynos_tmu.c
    @@ -1209,6 +1209,8 @@ err_clk_sec:
    if (!IS_ERR(data->clk_sec))
    clk_unprepare(data->clk_sec);
    err_sensor:
    + if (!IS_ERR_OR_NULL(data->regulator))
    + regulator_disable(data->regulator);
    thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd);

    return ret;



    \
     
     \ /
      Last update: 2015-08-14 20:01    [W:4.097 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site