lkml.org 
[lkml]   [2015]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 07/11] usb: otg: add OTG core
Hi Peter,

On 13/07/15 13:20, Roger Quadros wrote:
> On 13/07/15 05:14, Peter Chen wrote:
>> On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote:
>>> The OTG core instantiates the OTG Finite State Machine
>>> per OTG controller and manages starting/stopping the
>>> host and gadget controllers based on the bus state.
>>>
>>> It provides APIs for the following tasks
>>>
>>> - Registering an OTG capable controller
>>> - Registering Host and Gadget controllers to OTG core
>>> - Providing inputs to and kicking the OTG state machine
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> MAINTAINERS | 4 +-
>>> drivers/usb/Kconfig | 2 +-
>>> drivers/usb/Makefile | 1 +
>>> drivers/usb/common/Makefile | 3 +-
>>> drivers/usb/common/usb-otg.c | 768 +++++++++++++++++++++++++++++++++++++++++++
>>> drivers/usb/common/usb-otg.h | 71 ++++
>>> drivers/usb/core/Kconfig | 11 +-
>>> include/linux/usb/otg.h | 91 ++++-
>>> 8 files changed, 930 insertions(+), 21 deletions(-)
>>> create mode 100644 drivers/usb/common/usb-otg.c
>>> create mode 100644 drivers/usb/common/usb-otg.h
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 8133cef..b21278e 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -10640,12 +10640,14 @@ S: Maintained
>>> F: Documentation/usb/ohci.txt
>>> F: drivers/usb/host/ohci*
>>>
>>> -USB OTG FSM (Finite State Machine)
>>> +USB OTG/DRD core and FSM (Finite State Machine)
>>> M: Peter Chen <Peter.Chen@freescale.com>
>>> +M: Roger Quadros <rogerq@ti.com>
>>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
>>> L: linux-usb@vger.kernel.org
>>> S: Maintained
>>> F: drivers/usb/common/usb-otg-fsm.c
>>> +F: drivers/usb/common/usb-otg.c
>>>
>>> USB OVER IP DRIVER
>>> M: Valentina Manea <valentina.manea.m@gmail.com>
>>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>>> index 8ed451d..5b625e2 100644
>>> --- a/drivers/usb/Kconfig
>>> +++ b/drivers/usb/Kconfig
>>> @@ -32,7 +32,7 @@ if USB_SUPPORT
>>> config USB_COMMON
>>> tristate
>>> default y
>>> - depends on USB || USB_GADGET
>>> + depends on USB || USB_GADGET || USB_OTG
>>>
>>
>> USB_OTG can depends on USB || UB_GADGET?
>
> I didn't understand. The above is for USB_COMMON.
>
>>
>>> config USB_ARCH_HAS_HCD
>>> def_bool y
>>> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
>>> index d8926c6..769d13b 100644
>>> --- a/drivers/usb/Makefile
>>> +++ b/drivers/usb/Makefile
>>> @@ -60,5 +60,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/
>>> obj-$(CONFIG_USB_GADGET) += gadget/
>>>
>>> obj-$(CONFIG_USB_COMMON) += common/
>>> +obj-$(CONFIG_USB_OTG) += common/
>>>
>>
>> The comment like above.
>
> What should it look like?
>

Can you please clarify what you meant at the above two
comments? Thanks.

cheers,
-roger


\
 
 \ /
  Last update: 2015-08-14 12:21    [W:0.154 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site