Messages in this thread Patch in this message | | | Date | Thu, 13 Aug 2015 01:04:21 -0700 | From | tip-bot for Andi Kleen <> | Subject | [tip:perf/core] perf sort: Check for SRCLINE_UNKNOWN case in " srcfile" processing |
| |
Commit-ID: 76b10655818c939e257377f83992975a5f55ffb3 Gitweb: http://git.kernel.org/tip/76b10655818c939e257377f83992975a5f55ffb3 Author: Andi Kleen <ak@linux.intel.com> AuthorDate: Tue, 11 Aug 2015 06:36:55 -0700 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 12 Aug 2015 10:27:02 -0300
perf sort: Check for SRCLINE_UNKNOWN case in "srcfile" processing
Handle the SRCLINE_UNKNOWN case correctly when processing "srcfile".
Commiter note:
We can't just free it, as it was't allocated via malloc, its a guard variable.
Reported-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Link: http://lkml.kernel.org/r/20150811133655.GC4524@tassilo.jf.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/sort.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index c0c32b0..7e38716 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -330,6 +330,8 @@ static char *get_srcfile(struct hist_entry *e) sf = get_srcline(map->dso, map__rip_2objdump(map, e->ip), e->ms.sym, true); + if (!strcmp(sf, SRCLINE_UNKNOWN)) + return no_srcfile; p = strchr(sf, ':'); if (p && *sf) { *p = 0;
| |