lkml.org 
[lkml]   [2015]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wilc1000: Process WARN, INFO options of debug levels from user
On Wed, Aug 12, 2015 at 11:05:58PM +0530, Chandra S Gorentla wrote:
> - if (copy_from_user(buffer, buf, count)) {
> + ret = simple_write_to_buffer(buffer, sizeof(buffer), ppos, buf, count);

This part doesn't make sense. Use copy_from_user(). Also it's not NUL
terminated so it leads to a read past the end of the array later. In
the original code, we just looked at the first char and didn't use
kstrtoint() so we didn't care about NUL termination.

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-08-13 21:21    [W:0.030 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site