lkml.org 
[lkml]   [2015]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/15] hmm/dummy: dummy driver for testing and showcasing the HMM API
On Thu, Aug 13, 2015 at 03:45:40PM +0200, Sylvain Jeaugey wrote:
> Hi Jerome,
>
> I get a compilation error when building the hmm_dummy module (undefined
> function hmm_pte_test_select).
>
> On Fri, 17 Jul 2015, Jérôme Glisse wrote:
> > +static int dummy_mirror_pt_populate(struct hmm_mirror *mirror,
> > + struct hmm_event *event)
> > [ snip ]
> > + if (!mpte || !hmm_pte_test_valid_pfn(mpte) ||
> > + !hmm_pte_test_select(mpte)) {
> From what I understand, the select flag no longer exists in HMM PTE,
> hence hmm_pte_test_select is missing.
> Removing this sanity check, the module compiles and loads correctly.

This flag is added by remote memory patchset and i forgot that test
when splitting dummy driver in 2 patch.

> Aside from that problem, is there a userspace test available which
> interfaces with the dummy module ?

https://github.com/glisse/hmm-dummy-test-suite

I am trying to add more open source test with the dummy driver. But
they are some basic test already. Note that dummy driver is really
not meant to be use seriously beside as a test bed.

You can also find an updated patchset :

http://cgit.freedesktop.org/~glisse/linux/log/?h=hmm

I will probably repost including fixes made so far.

Cheers,
Jérôme


\
 
 \ /
  Last update: 2015-08-13 16:41    [W:0.040 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site