Messages in this thread | | | Date | Wed, 12 Aug 2015 15:40:10 +0100 | From | Morten Rasmussen <> | Subject | Re: [RFCv5 PATCH 20/46] sched: Relocated get_cpu_usage() and change return type |
| |
On Wed, Aug 12, 2015 at 12:59:23PM +0200, Peter Zijlstra wrote: > On Tue, Jul 07, 2015 at 07:24:03PM +0100, Morten Rasmussen wrote: > > +static unsigned long get_cpu_usage(int cpu) > > +{ > > + int sum; > > + unsigned long usage = cpu_rq(cpu)->cfs.utilization_load_avg; > > + unsigned long blocked = cpu_rq(cpu)->cfs.utilization_blocked_avg; > > + unsigned long capacity_orig = capacity_orig_of(cpu); > > + > > + sum = usage + blocked; > > + > > + if (sum >= capacity_orig) > > + return capacity_orig; > > + > > + return sum; > > +} > > Should sum then not also be unsigned long?
Yes it should. So much for my attempt at fixing the types :(
| |