lkml.org 
[lkml]   [2015]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature
On Tue, Aug 11, 2015 at 04:30:13PM +0530, Srikar Dronamraju wrote:
> Variable sched_numa_balancing is available for both CONFIG_SCHED_DEBUG
> and !CONFIG_SCHED_DEBUG. All code paths now check for
> sched_numa_balancing. Hence remove sched_feat(NUMA).
>
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/sched/core.c | 6 ------
> kernel/sched/features.h | 16 ----------------
> 2 files changed, 22 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7cbdf44..d02570b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2063,12 +2063,6 @@ __read_mostly bool sched_numa_balancing;
> void set_numabalancing_state(bool enabled)
> {
> sched_numa_balancing = enabled;
> -#ifdef CONFIG_SCHED_DEBUG
> - if (enabled)
> - sched_feat_set("NUMA");
> - else
> - sched_feat_set("NO_NUMA");
> -#endif /* CONFIG_SCHED_DEBUG */
> }

Could you at least replace sched_numa_balancing with a static_key
thingy?


\
 
 \ /
  Last update: 2015-08-11 13:21    [W:1.166 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site