lkml.org 
[lkml]   [2015]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue
Hi Ricardo,

Thanks for the review.

On 08/11/2015 12:00 PM, Ricardo Ribalda Delgado wrote:
> Hello Jacek
>
> Sorry for the late reply.
>
> On Tue, Aug 11, 2015 at 11:37 AM, Jacek Anaszewski
> <j.anaszewski@samsung.com> wrote:
>
>
>> struct pca963x_led {
>> struct pca963x *chip;
>> - struct work_struct work;
>> enum led_brightness brightness;
>> struct led_classdev led_cdev;
>> int led_num; /* 0 .. 15 potentially */
>> - enum pca963x_cmd cmd;
>> char name[32];
>> u8 gdc;
>> u8 gfrq;
>> };
>
> Maybe you want to remove also brightness, gdc and gfrq and pass them
> as arguments to the functions.
>
>> -static void pca963x_blink_work(struct pca963x_led *pca963x)
>> +static void pca963x_blink(struct pca963x_led *pca963x)
>
> something like: blink(pca963x, gdc, gfrq)

OK, I'll check it.

>
> Big disclaimer: i havent tested it on real hardware. Maybe next week I
> can get hold of a board with a pca chip.
>
>
> BTW: great thing that the work queue is implemented in the core :)

So far it is only in this patch set, but hopefully we will manage
to merge it soon.

--
Best Regards,
Jacek Anaszewski


\
 
 \ /
  Last update: 2015-08-11 13:01    [W:0.186 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site