Messages in this thread | | | Date | Mon, 10 Aug 2015 19:11:49 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH 18/23] power/reset: at91-reset: get and use slow clock |
| |
Hi,
On Mon, Aug 10, 2015 at 05:50:05PM +0200, Alexandre Belloni wrote: > On 05/08/2015 at 20:22:20 +0200, Sebastian Reichel wrote : > > On Fri, Jul 31, 2015 at 11:39:54AM +0200, Alexandre Belloni wrote: > > > Commit dca1a4b5ff6e ("clk: at91: keep slow clk enabled to prevent system > > > hang") added a workaround for the slow clock as it is not properly handled > > > by its users. > > > > > > Get and use the slow clock as it is necessary for the at91 reset > > > controller. > > > > You call clk_prepare_enable during probe without a matching > > clk_disable_unprepare on module removal. > > They will never be compiled as modules as the Kconfig option is a > bool so we don't have a .remove and the module will never be removed.
In that case the module_platform_driver() statement at the bottom should be replaced with builtin_platform_driver().
> Do you want me to change at91-reset and at91-poweroff to work as > modules?
That would also be fine.
-- Sebastian [unhandled content-type:application/pgp-signature] | |