Messages in this thread | | | Date | Sat, 1 Aug 2015 16:52:51 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) |
| |
On 31-07-15, 09:58, Dmitry Torokhov wrote: > On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote: > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > > is no need to do that again from its callers. Drop it. > > I'd rather keep it as it documents the expected behavior and double > unlikely should work just fine.
TBH, I don't really agree that it is there for documentation. The only purpose of such compiler flags is to try make code more efficient.
Anyway, I got to this series as someone asked me to fix this for one of my patches which used unlikely(IS_ERR_OR_NULL()). And so I thought about fixing all sites that are doing double unlikely (that shouldn't hurt for sure).
I will leave it to you.
-- viresh
| |