Messages in this thread | | | Date | Sat, 1 Aug 2015 21:17:41 +0200 | From | Thomas Graf <> | Subject | Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive() |
| |
On 07/31/15 at 10:51am, Joe Stringer wrote: > On 31 July 2015 at 07:34, Hannes Frederic Sowa <hannes@redhat.com> wrote: > > In general, this shouldn't be necessary as the packet should already be > > scrubbed before they arrive here. > > > > Could you maybe add a WARN_ON and check how those skbs with conntrack > > data traverse the stack? I also didn't understand why make it dependent > > on the socket. > > OK, sure. One case I could think of is with an OVS internal port in > another namespace, directly attached to the bridge. I'll have a play > around with WARN_ON and see if I can come up with something more > trimmed down.
The OVS internal port will definitely pass through an unscrubbed packet across namespaces. I think the proper thing to do would be to scrub but conditionally keep metadata.
| |