Messages in this thread | | | Date | Thu, 9 Jul 2015 22:32:57 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH v4 6/7] imx27: dt: add support of internal rtc |
| |
On Sat, Jul 04, 2015 at 01:15:19AM +0200, Philippe Reynes wrote: > Add support of internal rtc on imx27. > > Signed-off-by: Philippe Reynes <tremyfr@gmail.com> > --- > arch/arm/boot/dts/imx27.dtsi | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index b69be5c..38e6e84 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -144,6 +144,16 @@ > clock-names = "ipg", "per"; > }; > > + rtc: rtc@10007000 { > + compatible = "fsl,imx21-rtc"; > + reg = <0x10007000 0x1000>; > + interrupts = <22>; > + clocks = <&clks IMX27_CLK_CKIL>, > + <&clks IMX27_CLK_RTC_IPG_GATE>; > + clock-names = "rtc", "ipg"; > + status = "disabled";
It has neither pin-out nor board level configuration. For such device, it makes more sense to drop status = "disabled" and enable the device by default. The bonus point would be that patch #7 in the series can be saved.
Shawn
> + }; > + > kpp: kpp@10008000 { > compatible = "fsl,imx27-kpp", "fsl,imx21-kpp"; > reg = <0x10008000 0x1000>; > -- > 1.7.4.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
| |