lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/42] x86, boot: Allow 64bit EFI kernel to be loaded above 4G
On Tue, 07 Jul, at 04:12:26PM, Kees Cook wrote:
> > @@ -301,7 +301,7 @@ _start:
> > # Part 2 of the header, from the old setup.S
> >
> > .ascii "HdrS" # header signature
> > - .word 0x020d # header version number (>= 0x0105)
> > + .word 0x020e # header version number (>= 0x0105)
> > # or else old loadlin-1.5 will fail)
> > .globl realmode_swtch
> > realmode_swtch: .word 0, 0 # default_switch, SETUPSEG
> > @@ -478,6 +478,7 @@ pref_address: .quad LOAD_PHYSICAL_ADDR # preferred load addr
> > #endif
> > init_size: .long INIT_SIZE # kernel initialization size
> > handover_offset: .long 0 # Filled in by build.c
> > +ext_code32_start: .long 0 # werid one!
>
> Comment is a typo?

Yeah, this was one of the things I pointed out the last time this patch
was sent and it's disheartening to see it wasn't fixed (as trivial as it
may be),

https://lkml.kernel.org/r/20150224215501.GB9758@codeblueprint.co.uk

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-07-08 20:21    [W:0.084 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site