Messages in this thread | | | Date | Wed, 08 Jul 2015 12:47:26 +0200 | From | Hannes Reinecke <> | Subject | Re: [PATCH v3 2/3] megaraid_sas : use dev_printk when possible |
| |
On 07/07/2015 10:52 PM, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages more useful. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 304 +++++++++++++-------------- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 95 ++++---- > 2 files changed, 196 insertions(+), 203 deletions(-) > [ .. ] > @@ -1873,8 +1872,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance, > cmd = megasas_get_cmd(instance); > > if (!cmd) { > - printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation_111:" > - "Failed to get cmd for scsi%d.\n", > + dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" > + "Failed to get cmd for scsi%d\n", > instance->host->host_no); > return -ENOMEM; > } Makes one wonder why we don't have a 'dev_debug'; dev_notice() and dev_warn() are there ...
Otherwise: Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
| |