Messages in this thread | | | Date | Tue, 7 Jul 2015 23:41:07 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction |
| |
On (07/07/15 22:44), Minchan Kim wrote: [..] > IMO, there is no value to maintain just in case of > failing register_shrinker in practice. > > Let's remove shrinker_enabled and abort pool creation if shrinker register > is failed.
But why would we do this? Yes, it's kinda-sorta bad -- we were not able to register zspool shrinker, so there will be no automatic compaction... And that's it.
It does not affect zsmalloc/zram functionality by any means. Including compaction itself -- user still has a way to compact zspool (manually). And in some scenarios user will never even see automatic compaction in action (assuming that there is a plenty of RAM available).
Can you explain your decision?
-ss
| |