Messages in this thread | | | Date | Tue, 07 Jul 2015 07:48:00 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH 1/1] block: use FIELD_SIZEOF to calculate size of a field |
| |
On 07/07/2015 01:11 AM, Maninder Singh wrote: > use FIELD_SIZEOF instead of open coding > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > --- > block/blk-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-core.c b/block/blk-core.c > index 688ae94..5a9792e 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -3298,7 +3298,7 @@ EXPORT_SYMBOL(blk_post_runtime_resume); > int __init blk_dev_init(void) > { > BUILD_BUG_ON(__REQ_NR_BITS > 8 * > - sizeof(((struct request *)0)->cmd_flags)); > + FIELD_SIZEOF(struct request, cmd_flags)); > > /* used for unplugging and affects IO latency/throughput - HIGHPRI */ > kblockd_workqueue = alloc_workqueue("kblockd",
Applied, thanks.
-- Jens Axboe
| |