lkml.org 
[lkml]   [2015]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFCv3 5/5] mm: remove direct calling of migration
    Date
    From: Gioh Kim <gurugio@hanmail.net>

    Migration is completely generalized so that migrating mobile page
    is processed with lru-pages in move_to_new_page.

    Signed-off-by: Gioh Kim <gioh.kim@lge.com>
    ---
    mm/balloon_compaction.c | 8 --------
    mm/migrate.c | 13 -------------
    2 files changed, 21 deletions(-)

    diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
    index 0dd0b0d..9d07ed9 100644
    --- a/mm/balloon_compaction.c
    +++ b/mm/balloon_compaction.c
    @@ -170,13 +170,6 @@ int balloon_page_migrate(struct address_space *mapping,
    if (!isolated_balloon_page(page))
    return rc;

    - /*
    - * Block others from accessing the 'newpage' when we get around to
    - * establishing additional references. We should be the only one
    - * holding a reference to the 'newpage' at this point.
    - */
    - BUG_ON(!trylock_page(newpage));
    -
    if (WARN_ON(!__is_movable_balloon_page(page))) {
    dump_page(page, "not movable balloon page");
    unlock_page(newpage);
    @@ -186,7 +179,6 @@ int balloon_page_migrate(struct address_space *mapping,
    if (balloon && balloon->migratepage)
    rc = balloon->migratepage(balloon, newpage, page, mode);

    - unlock_page(newpage);
    return rc;
    }

    diff --git a/mm/migrate.c b/mm/migrate.c
    index e22be67..b82539b 100644
    --- a/mm/migrate.c
    +++ b/mm/migrate.c
    @@ -844,19 +844,6 @@ static int __unmap_and_move(struct page *page, struct page *newpage,
    }
    }

    - if (unlikely(mobile_page(page))) {
    - /*
    - * A mobile page does not need any special attention from
    - * physical to virtual reverse mapping procedures.
    - * Skip any attempt to unmap PTEs or to remap swap cache,
    - * in order to avoid burning cycles at rmap level, and perform
    - * the page migration right away (proteced by page lock).
    - */
    - rc = page->mapping->a_ops->migratepage(page->mapping,
    - newpage, page, mode);
    - goto out_unlock;
    - }
    -
    /*
    * Corner case handling:
    * 1. When a new swap-cache page is read into, it is added to the LRU
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-07-07 07:01    [W:4.115 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site