Messages in this thread | | | Date | Tue, 7 Jul 2015 10:45:32 +0200 | Subject | Re: [PATCH] [SCSI] FlashPoint: optimize string comparison | From | Frans Klaver <> |
| |
On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > Stop comparing the strings as soon as we know that they don't match. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/scsi/FlashPoint.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c > index 5c74e4c..24a4d1a 100644 > --- a/drivers/scsi/FlashPoint.c > +++ b/drivers/scsi/FlashPoint.c > @@ -6280,8 +6280,10 @@ static unsigned char FPT_scmachid(unsigned char p_card, > match = 1; > > for (k = 0; k < ID_STRING_LENGTH; k++) { > - if (p_id_string[k] != FPT_scamInfo[i].id_string[k]) > + if (p_id_string[k] != FPT_scamInfo[i].id_string[k]) { > match = 0; > + break; > + } > } > > if (match) {
Why doesn't this use strncmp?
Thanks, Frans
| |