Messages in this thread Patch in this message | | | From | Yinghai Lu <> | Subject | [PATCH 10/36] PCI: Add debug printout during releasing partial must/optinal assigned resources | Date | Mon, 6 Jul 2015 16:39:00 -0700 |
| |
We try to assign must+optional at first, and we only accept the result if all resources get allocated. Otherwise will release them, and try to assign must and expand to optional.
We have to do that to make sure any must has priority than any optional addon.
When that happens, we only print out "assigned" info, that is confusing as it looks like same range is assigned to two peer resources at the same time.
Add printout for releasing so we have whole picture in debug messages.
Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/pci/setup-bus.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 405eb1d..62dd8b7 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -516,9 +516,17 @@ static void __assign_resources_sorted(struct list_head *head, free_list(&local_fail_head); /* Release assigned resource */ - list_for_each_entry(dev_res, head, list) - if (dev_res->res->parent) - release_resource(dev_res->res); + list_for_each_entry(dev_res, head, list) { + struct resource *res = dev_res->res; + + if (res->parent) { + dev_printk(KERN_DEBUG, &dev_res->dev->dev, + "BAR %d: released %pR\n", + (int)(res - &dev_res->dev->resource[0]), + res); + release_resource(res); + } + } /* Restore start/end/flags from saved list */ list_for_each_entry(save_res, &save_head, list) { struct resource *res = save_res->res; -- 1.8.4.5
| |