lkml.org 
[lkml]   [2015]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: misc: bma150: use sign_extend32() for sign extending
On Fri, Jul 03, 2015 at 01:13:01AM +0200, Martin Kepplinger wrote:
> Despite it's name, sign_extend32() is used for 16 bit values aswell.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>

Applied, thank you.

> ---
> drivers/input/misc/bma150.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index b36831c..c278049 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150)
> y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
> z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
>
> - /* sign extension */
> - x = (s16) (x << 6) >> 6;
> - y = (s16) (y << 6) >> 6;
> - z = (s16) (z << 6) >> 6;
> + x = sign_extend32(x, 9);
> + y = sign_extend32(y, 9);
> + z = sign_extend32(z, 9);
>
> input_report_abs(bma150->input, ABS_X, x);
> input_report_abs(bma150->input, ABS_Y, y);
> --
> 2.1.4
>

--
Dmitry


\
 
 \ /
  Last update: 2015-07-07 01:21    [W:0.026 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site