Messages in this thread | | | Date | Fri, 31 Jul 2015 07:33:20 +0530 | Subject | Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate | From | Vaishali Thakkar <> |
| |
On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote: >> For simple modules that contain a single xt_match without any >> additional setup code then ends up being a block of duplicated >> boilerplate. This patch adds a new macro, module_xt_match(), >> which replaces the module_init()/module_exit() registrations with >> template functions. > > I prefer not to use this macro, we may need to add something to the > module_init()/module_exit() path in the future to these netfilter > extensions and then we'll have to revert the follow up conversions > patches that you will likely send.
Ok. This makes sense. I think in that case you can drop the patch.
Thank You.
> Thanks anyway.
-- Vaishali
| |