Messages in this thread | | | Date | Thu, 30 Jul 2015 09:33:07 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] kdbus/samples: skip on CROSS_COMPILE |
| |
On Thu, Jul 30, 2015 at 06:13:25PM +0200, David Herrmann wrote: > Apparently we cannot rely on up-to-date kernel headers to be available > when cross-compiling, not even for HOSTCC. That's sad, but it's how it > is. Skip samples on cross-compiles as suggested by Paul, so allmodconfig > runs smoothly again. > > Tested-by: Paul Gortmaker <paul.gortmaker@windriver.com> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > --- > samples/kdbus/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/samples/kdbus/Makefile b/samples/kdbus/Makefile > index 137f842..dbd9de8 100644 > --- a/samples/kdbus/Makefile > +++ b/samples/kdbus/Makefile > @@ -1,9 +1,13 @@ > # kbuild trick to avoid linker error. Can be omitted if a module is built. > obj- := dummy.o > > +ifndef CROSS_COMPILE
This really feels like the wrong solution.
> + > hostprogs-$(CONFIG_SAMPLE_KDBUS) += kdbus-workers > > always := $(hostprogs-y) > > HOSTCFLAGS_kdbus-workers.o += -I$(objtree)/usr/include > HOSTLOADLIBES_kdbus-workers := -lrt > + > +endif
Shuah, how should we fix this "properly"? How is this resolved for the kernel test scripts, it should have the same issue that the samples do.
thanks,
greg k-h
| |