Messages in this thread | | | Date | Thu, 30 Jul 2015 14:02:35 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH] x86/mm, efi: Check for valid image type |
| |
On Wed, 29 Jul, at 05:37:52PM, Dave Young wrote: > > Not sure if BGRT is useful in kexec kernel, it seems not worth to copy > it between kernels. > > IMO just return in case if (efi_setup) is true make sense.
Yes, I think it makes sense to skip touching the BGRT on kexec boot.
As a side note, we should really look at using one of the efi_enabled() bits to signal when we're booting a kexec'd kernel because it is not at all obvious that 'efi_setup != 0' means we're in kexec kernel.
But that wants to be a separate patch from this issue.
-- Matt Fleming, Intel Open Source Technology Center
| |