Messages in this thread | | | Date | Thu, 30 Jul 2015 10:12:11 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v5 3/8] clk: add support for clocks provided by SCP(System Control Processor) |
| |
On 29/07/15 18:37, Stephen Boyd wrote: > On 07/23/2015 04:10 AM, Sudeep Holla wrote: >> On some ARM based systems, a separate Cortex-M based System Control >> Processor(SCP) provides the overall power, clock, reset and system >> control. System Control and Power Interface(SCPI) Message Protocol >> is defined for the communication between the Application Cores(AP) >> and the SCP. >> >> This patch adds support for the clocks provided by SCP using SCPI >> protocol. >> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> Cc: Mike Turquette <mturquette@baylibre.com> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Cc: Liviu Dudau <Liviu.Dudau@arm.com> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Cc: Jon Medhurst (Tixy) <tixy@linaro.org> >> Cc: linux-clk@vger.kernel.org > > Looks good to me, modulo one comment. > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> >
Thanks, I assume you are fine if this gets merged via arm-soc
>> + >> +static const struct of_device_id scpi_clocks_ids[] = { >> + { .compatible = "arm,scpi-clocks", }, >> + {} >> +}; > > Did you want a MODULE_DEVICE_TABLE() here? >
Yes, I do and it's added now.
Regards, Sudeep
| |