lkml.org 
[lkml]   [2015]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode
Hi Thomas,

On 01/07/2015 17:54, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote:
>
>> static void __init mvebu_init_irq(void)
>> {
>> + if (of_machine_is_compatible("marvell,armada375") ||
>> + of_machine_is_compatible("marvell,armada380") ||
>> + of_machine_is_compatible("marvell,armada390"))
>
> What we really want to know is if we're using the GIC, so what about
> instead:
>
> np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> if (np)
> gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
> IRQCHIP_MASK_ON_SUSPEND);
> of_node_put(np);
>
> (Not even compile-tested).

Indeed it is better. I will make the change.

Thanks,

Gregory


>
> Thanks,
>
> Thomas
>


--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


\
 
 \ /
  Last update: 2015-07-03 09:41    [W:1.365 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site