Messages in this thread | | | Date | Fri, 3 Jul 2015 13:06:51 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 36/51] writeback: implement bdi_for_each_wb() |
| |
On Fri, Jul 03, 2015 at 02:26:27PM +0200, Jan Kara wrote: > That's a good point. Thanks for explanation. Maybe add a comment like: > /* > * We use use this seemingly complicated 'for' loop so that 'break' and > * 'continue' continue to work as expected. > */
This kinda feel superflous for me. This is something true for all iteration wrappers which falls within the area of well-established convention, I think. If it's doing something weird like combining if-else clause to do post-conditional processing, sure, but this is really kinda standard.
Thanks.
-- tejun
| |