Messages in this thread | | | Date | Fri, 3 Jul 2015 18:10:37 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() |
| |
On Fri, Jul 03, 2015 at 09:09:12AM -0700, Cong Wang wrote: > On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote: > > According to the comments, we need to test if this is > > the first throttled task, however, list_empty() tests on > > the entry cfs_rq->throttled_list, not the head, this is wrong. > > > > This is a bug because we don't re-init the list entry after > > removing it from the list, so list_empty() could return false > > even if the list is really empty. > > > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > Signed-off-by: Cong Wang <cwang@twopensource.com> > > ping. > > What's the status of this patch?
Queued, will likely hit tip after the merge window etc has settled.
| |