lkml.org 
[lkml]   [2015]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization
Date
On Jul 1, 2015, at 7:54 PM, Stephen Boyd wrote:

>>
>> + /* Returns -1 if error */
>> + ret = hvc_instantiate(0, 0, &hvc_dcc_get_put_ops);
>> +
>> + return ret < 0 ? -ENODEV : 0;
>
> Why not just return the value that hvc_instantiate returns? And maybe we
> should change those -1 in hvc_instantiate into -EPERM?

Well, I didn't want to change common HVC code. I would have to change all the other drivers that call hvc_instatiate as well. I agree that returning -1 is bad, but fixing that is something that should be done in another patch.

>>
>> - hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128);
>> - return 0;
>> + p = hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128);
>> +
>> + return IS_ERR(p) ? PTR_ERR(p) : 0;
>
> return PTR_ERR_OR_ZERO()?

Yes, thanks. I'll change it.



\
 
 \ /
  Last update: 2015-07-03 17:21    [W:0.109 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site