lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] misc: eeprom: clean up eeprom_read()
On Mon, 27 Jul 2015 00:18:49 +0300, Vladimir Zapolskiy wrote:
> The change removes redundant sysfs binary file boundary check, since
> this task is already done on caller side in fs/sysfs/file.c
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> ---
> drivers/misc/eeprom/eeprom.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
> index b432873..7342fd6 100644
> --- a/drivers/misc/eeprom/eeprom.c
> +++ b/drivers/misc/eeprom/eeprom.c
> @@ -88,11 +88,6 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,
> struct eeprom_data *data = i2c_get_clientdata(client);
> u8 slice;
>
> - if (off > EEPROM_SIZE)
> - return 0;
> - if (off + count > EEPROM_SIZE)
> - count = EEPROM_SIZE - off;
> -
> /* Only refresh slices which contain requested bytes */
> for (slice = off >> 5; slice <= (off + count - 1) >> 5; slice++)
> eeprom_update_client(client, slice);

Thanks for the clean-up.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--
Jean Delvare
SUSE L3 Support


\
 
 \ /
  Last update: 2015-07-29 21:10    [W:0.167 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site