lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] x86/pci/intel-mid-pci: fix to get eMMC detected
On Wed, 29 Jul 2015, Andy Shevchenko wrote:

> On Intel Edison we have an interesting implementation of x86 platform without
> legacy PIC and with specific PCI. There are devices which are not using
> interrupt line 0, but have it assigned in the PCI configuration. By default
> first come gets it, though the first eMMC host controller is the actual user
> for IRQ0.
>
> So, this series provides a quirk (patch 1) to resolve the issue, a small fix of
> error code (patch 2), and a sparse warning fix (patch 3).
>
> Changelog v3:
> - address Thomas' comments
> - massage changelog (what Thomas proposed)
>
> Andy Shevchenko (3):
> x86/pci/intel_mid_pci: work around for IRQ0 assignment
> x86/pci/intel_mid_pci: propagate actual return code
> x86/pci/intel_mid_pci: fix a sparse warning

I've picked them up. If you get the tip-bot mails, you might notice a
few edits on the changelogs.

- Sentence starts with an upper case letter.

- You cannot fix a sparse warning.

- "This patch does ...." is just horrible. When one reads a patch
he already knows that it is a patch.

Please avoid these things in the future.

Thanks,

tglx


\
 
 \ /
  Last update: 2015-07-29 22:21    [W:0.043 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site