lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
    Greg,

    At this point I've got Reviewed-by from Rob on the binding and dts bits,
    and Reviewed-by from Andy Gross on the complete patch series (v3).

    I believe I've addressed all issues raised. Can you please add this
    (v3) to drivers/misc?

    Let me know if you want me to re-send anything.

    Thanks very much.
    -- Tim


    On 07/17/2015 08:42 AM, Rob Herring wrote:
    > On Thu, Jul 16, 2015 at 6:55 PM, Tim Bird <tim.bird@sonymobile.com> wrote:
    >> This binding is used to configure the driver for the coincell charger
    >> found in Qualcomm PMICs.
    >>
    >> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
    >
    > Reviewed-by: Rob Herring <robh@kernel.org>
    >
    >> ---
    >>
    >> Changes in v3:
    >> - change charge-enable property to charger-disable
    >> Changes in v2:
    >> - remove 'qcom,' from example node name
    >> - Added reference to parent node pm8941@0 and binding doc for it
    >>
    >> .../bindings/power/qcom,coincell-charger.txt | 48 ++++++++++++++++++++++
    >> 1 file changed, 48 insertions(+)
    >> create mode 100644 Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
    >>
    >> diff --git a/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
    >> new file mode 100644
    >> index 0000000..0e6d875
    >> --- /dev/null
    >> +++ b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
    >> @@ -0,0 +1,48 @@
    >> +Qualcomm Coincell Charger:
    >> +
    >> +The hardware block controls charging for a coincell or capacitor that is
    >> +used to provide power backup for certain features of the power management
    >> +IC (PMIC)
    >> +
    >> +- compatible:
    >> + Usage: required
    >> + Value type: <string>
    >> + Definition: must be: "qcom,pm8941-coincell"
    >> +
    >> +- reg:
    >> + Usage: required
    >> + Value type: <u32>
    >> + Definition: base address of the coincell charger registers
    >> +
    >> +- qcom,rset-ohms:
    >> + Usage: required
    >> + Value type: <u32>
    >> + Definition: resistance (in ohms) for current-limiting resistor
    >> + must be one of: 800, 1200, 1700, 2100
    >> +
    >> +- qcom,vset-millivolts:
    >> + Usage: required
    >> + Value type: <u32>
    >> + Definition: voltage (in millivolts) to apply for charging
    >> + must be one of: 2500, 3000, 3100, 3200
    >> +
    >> +- qcom,charger-disable:
    >> + Usage: optional
    >> + Value type: <boolean>
    >> + Definition: definining this property disables charging
    >> +
    >> +This charger is a sub-node of one of the 8941 PMIC blocks, and is specified
    >> +as a child node in DTS of that node. See ../mfd/qcom,spmi-pmic.txt and
    >> +../mfd/qcom-pm8xxx.txt
    >> +
    >> +Example:
    >> +
    >> + pm8941@0 {
    >> + coincell@2800 {
    >> + compatible = "qcom,pm8941-coincell";
    >> + reg = <0x2800>;
    >> +
    >> + qcom,rset-ohms = <2100>;
    >> + qcom,vset-millivolts = <3000>;
    >> + };
    >> + };
    >> --
    >> 1.8.2.2
    >>


    \
     
     \ /
      Last update: 2015-07-29 21:21    [W:2.536 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site