Messages in this thread | | | Date | Wed, 29 Jul 2015 08:49:31 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH -mm v2] sound: convert to parse_integer() |
| |
On Tue, 28 Jul 2015 23:06:15 +0200, Andrew Morton wrote: > > On Tue, 28 Jul 2015 00:03:01 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote: > > > Convert away from deprecated simple_strto*() interfaces to > > parse_integer() and kstrto*(). > > The patch does a lot more than this! It also adds lots of handling of > previously-ignored errors.
Yes, please give more description.
> And it thereby introduces possible back-compatibility issues. Someone > who is doing "echo 42foo > wherever" will now get an error, whereas > they previously got 42.
Right, many strings don't care about spaces, i.e. it contains trailing spaces, so the patch seems doing way too strict. I think it's better to omit the word termination check in each place.
> So hm. Probably a good patch and I'll stick it in -mm for testing, but > this should go upstream via tiwai, please.
Well, but parse_integer() isn't upstreamed yet, so it has to be after mm tree, right?
thanks,
Takashi
| |