Messages in this thread | | | Date | Wed, 29 Jul 2015 12:27:07 +0100 | From | Julien Grall <> | Subject | Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies |
| |
Hi Chris,
On 28/07/15 20:39, Chris (Christopher) Brand wrote: >> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, >> I suspect this is because the first support for Xen was for PV. This brough some > Typo : "brought" > Perhaps "resulted in" would be better ? > >> misimplementation of helpers on ARM and make the developper confused the expected behavior. > Typo: "developer". > I'd also suggest "...and confused developers about the...". > > [...] > >> For clarity and avoid new confusion, replace any reference of mfn into gnf in any helpers used by PV drivers. > Typo : "gfn" > I'd suggest "...replace any reference to mfn with gfn..." > > [...]
Thanks for telling me the typoes. I will fix it in the next version of this series.
Regards,
-- Julien Grall
| |