lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Update 2x][PATCH 7/7] cpufreq: Separate CPU device registration from CPU online
On 29-07-15, 03:03, Rafael J. Wysocki wrote:
> +static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif)
> +{
> + unsigned cpu = dev->id;
> + int ret;
> +
> + dev_dbg(dev, "%s: adding CPU%u\n", __func__, cpu);
> +
> + if (cpu_online(cpu)) {
> + ret = cpufreq_online(cpu);

I will do return right here ...

> + } else {

... and this else will not be required anymore.

> + /*
> + * A hotplug notifier will follow and we will handle it as CPU
> + * online then. For now, just create the sysfs link, unless
> + * there is no policy or the link is already present.
> + */
> + struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
> +
> + ret = policy && !cpumask_test_and_set_cpu(cpu, policy->real_cpus)
> + ? add_cpu_dev_symlink(policy, cpu) : 0;
> + }
> +
> + return ret;
> +}

Looks good otherwise.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh


\
 
 \ /
  Last update: 2015-07-29 20:40    [W:0.118 / U:1.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site