lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/4] toshiba_acpi: Change *available functions return type
    On Mon, Jul 27, 2015 at 07:22:25PM -0600, Azael Avalos wrote:
    > This patch changes the *available functions return type from int to
    > void.
    >
    > The checks for support of their respective features are done inside
    > such functions and there was no need to return anything as we can
    > flag the queried feature as supported inside these functions.
    >
    > The code was adapted accordingly to these changes and two new
    > variables were created and another was changed from uint to bool.
    >
    > While at the neighborhood, some of the functions were cleaned from

    Please consider this a red flag in the future. "While in the neighborhood" means
    you need to split the patch across distinct functional boundaries.

    --
    Darren Hart
    Intel Open Source Technology Center


    \
     
     \ /
      Last update: 2015-07-29 20:40    [W:3.179 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site