Messages in this thread | | | Date | Tue, 28 Jul 2015 14:02:18 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH] user_ns: use correct check for single-threadedness |
| |
On 07/28/2015 01:15 PM, Kees Cook wrote: > From: Ricky Zhou <rickyz@chromium.org> > > Checking mm_users > 1 does not mean a process is multithreaded. For > example, reading /proc/PID/maps temporarily increments mm_users, allowing > other processes to (accidentally) interfere with unshare() calls. > > This fixes observed failures of unshare(CLONE_NEWUSER) incorrectly > returning EINVAL if another processes happened to be simultaneously > reading the maps file. > > Signed-off-by: Ricky Zhou <rickyz@chromium.org> > Signed-off-by: Kees Cook <keescook@chromium.org> > Cc: stable@vger.kernel.org
Reviewed-by: Rik van Riel <riel@redhat.com>
| |