Messages in this thread | | | Date | Tue, 28 Jul 2015 07:56:32 -0700 | From | Greg KH <> | Subject | Re: [PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes |
| |
On Tue, Jul 28, 2015 at 06:18:05PM +0530, Bhaktipriya Shridhar wrote: > This patch fixes: > 1.Fixes comments that are over 80-characters either by: > -breaking up comment lines, into multi-line comments (kernel style) or > -shortening comments (Done in 7 places): > - Changed "Why?Becuz" to "Since" (6 places) > - Removed the comment "Which I dont care about" (1 place) > 2.Fixes code lines that are over 80-characters by > -breaking up long math lines > -breaking up long function calls > 2.Spelling errors in comments. > -tho -> though > -baudrate -> baud rate
When listing all of the different things your patch does, that should be a huge hint that it should be broken up into lots of different patches.
Please do only one thing per patch.
thanks,
greg k-h
| |