lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample
On Mon, Jul 27, 2015 at 10:24:49PM +0000, Liang, Kan wrote:

SNIP

> > >freq_perf_data,
> > > + sample-
> > >read.group.values[nr].value);
> >
> > I think this should be in upper layer..
>
> OK, I'll move it to deliver_sample_group.
>
> > why not do this also within
> > iter_prepare_normal_entry as for the rest of the calculations I suggested
> > in my other email
>
> Because we cannot get evlist in iter_add/prepare function. We cannot go
> through all group members' value.
> It's too complex (need to change many interfaces) to pass the evlist to
> iter_add/prepare function

hum, I remember Namhyung added iter->add_entry_cb, but seems it's called
after the entry is added.. how about adding pre-addition callback?

it can reach the report structure with perf_evlist

jirka


\
 
 \ /
  Last update: 2015-07-28 16:21    [W:0.064 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site