lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date
On Tuesday, July 28, 2015 05:16:56 PM Sudip Mukherjee wrote:
> On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> > where the underlying struct has a 6 * unsigned char.
> > Simplify the calculation by just subtracting the variable part from
> > the size of the struct.
> >
> > This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> >
> > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> > ---
> <snip>
> >
> > u8 *r8712_get_capability_from_ie(u8 *ie)
>
> Something is wrong. The same patch is getting repeated in the same mail
> multiple times. I deleted almost 2500 lines after this before sending
> this reply. See how your patch is looking like:
> http://www.gossamer-threads.com/lists/linux/kernel/2224869
>
> regards
> sudip
>
Oh No!
I made a tweak to git-send-email to try to get past the problem with perl 5.22
That was causing git-send-email to crash.
The whole series, including the cover letter is like this.
I will resubmit when I have fixed this problem.


\
 
 \ /
  Last update: 2015-07-28 14:41    [W:0.041 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site