lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes
    From
    Date
    On Mon, 2015-07-27 at 03:21 -0700, Matthias Brugger wrote:
    > On Monday, July 27, 2015 10:56:22 AM James Liao wrote:
    > > Hi Daniel,
    > >
    > > On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote:
    > > > > @@ -88,6 +88,13 @@
    > > > >
    > > > > #clock-cells = <0>;
    > > > >
    > > > > };
    > > > >
    > > > > + cpum_ck: dummy_clk {
    > > >
    > > > I'm not a big fan of this "dummy_clk".
    > > > The 'name' part of the devicetree node is supposed to be generic.
    > > > So, perhaps just oscillator@2, and move it down below clk32k:
    > > > oscillator@1.
    > >
    > > > Otherwise:
    > > cpum_ck is a test clock which only available in IC test. It's empty on
    > > MT8173 evaluation or production boards. Should we name this kind of
    > > empty clock as an oscillator? Or is there a better name for it?
    > >
    >
    > So if it will never be part of any available boards, why do you want to add
    > it?

    infra_cpum is a clock gate, and its clock comes from an external clock.
    In previous versions we named the external clock as "clk_null", but it's
    not accepted. A specified name is preferred even it's not available on
    some boards. So I named it as cpum_ck in this patch.


    Best regards,

    James



    \
     
     \ /
      Last update: 2015-07-28 07:41    [W:3.762 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site