lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net 1/2] r8152: add pre_reset and post_reset
Date
Oliver Neukum [mailto:oneukum@suse.com]
> Sent: Tuesday, July 28, 2015 4:53 PM
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
> > + if (ret < 0)
> > + return ret;
>
> What sense does this make?
>
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
>
> The device will be awake.

I don't sure if the device would be in runtimesuspend, so I wake it up by myself.
I think you mean I don't have to do this. I would remove them and resend the
patch. Thanks.

Best Regards,
Hayes

\
 
 \ /
  Last update: 2015-07-28 12:41    [W:0.168 / U:4.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site