Messages in this thread Patches in this message | | | From | Joshua Clayton <> | Subject | [PATCH V3 3/8] staging: rtl8712: fix comment | Date | Mon, 27 Jul 2015 21:41:12 -0700 |
| |
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <stillcompiling@gmail.com> To: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Nitin Kuppelur <nitinkuppelur@gmail.com>, Joshua Clayton <stillcompiling@gmail.com>, Vaishali Thakkar <vthakkar1994@gmail.com>, Tapasweni Pathak <tapaswenipathak@gmail.com>, Daniel Baluta <daniel.baluta@intel.com>, Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>, Max Perepelitsyn <mperepelitsyn@gmail.com>, Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>, Cristina Opriceana <cristina.opriceana@gmail.com>, Dogukan Ergun <dogukan.ergun@gmail.com>, Julia Lawall <Julia.Lawall@lip6.fr>, Dan Carpenter <dan.carpenter@oracle.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com> References: <cover.1438057939.git.stillcompiling@gmail.com>
The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6
| |