Messages in this thread | | | Date | Tue, 28 Jul 2015 10:01:03 +0200 | From | Michal Hocko <> | Subject | Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI |
| |
On Tue 28-07-15 11:02:11, Hidehiro Kawai wrote: [...] > > Something like > [...] > > +void nmi_panic(const char *fmt, ...) > > Since we can't directly pass variable arguments to a subroutine,
Sure, I was just too lazy to finish this as it was just an illustration of the idea.
> we have to use a macro or do like this: > > void nmi_panic(const char *msg) > { > ... > panic("%s", msg); > } > > If there is no objection, I'm going to use a macro.
Your other patch needs panic_cpu externally visible so the macro should be OK. -- Michal Hocko SUSE Labs
| |