lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow
Date
Michal Suchanek wrote:
>
> Although there is only one choice of chipselect it is necessary to
> specify it. The driver cannot claim the gpio otherwise.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>

From here ---8<--------8<-----------

> --
> - don't move unrelated line
> - use symbolic GPIO_ACTIVE_HIGH

to here ---8<--------8<-----------

should be added under the following '---'.

Please add some additional comments like above 'changes since previous version'
under the following '---' not '--', because all comments will be logged before
the '---' and I don't want to keep the changes basically.

Anyway, applied with removing above comments.

Thanks,
Kukjin

> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index b7f4122..2d6a976 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -688,6 +688,7 @@
> status = "okay";
> samsung,spi-src-clk = <0>;
> num-cs = <1>;
> + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>;
> };
>
> &usbdrd_dwc3 {
> --
> 2.1.4



\
 
 \ /
  Last update: 2015-07-29 20:39    [W:0.076 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site